[test] Temporarily disable Reflection tests on non-macOS #19031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
…curses. I'll have to think harder about this. |
jrose-apple
force-pushed
the
links-are-hard
branch
from
f62b148 to
6ffe644
Compare
utils/remote-run will only run things in %t. An Apple-internal tool doesn't follow symlinks. Normal macOS and simulator runs find the support libraries relative to the binary. I'm not sure what to do yet, but for now let's unbreak the Apple-internal bots I broke in 01a0de2.
|
@swift-ci Please test |
jrose-apple
changed the title
|
Build failed |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
Force-merging to bring back internal bots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix-up for #18966. The change made there was in support of utils/remote-run, which won't run things that are outside of
%t, but it broke an internal testing tool at Apple, which doesn't follow symlinks.Use a hard link instead, which everything supports.Disable the tests on non-macOS for now while I think about this more.