[stdlib]remove _PointerFunction #17809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please smoke benchmark |
|
Build failed |
Build comment file:Optimized (O)Regression (19)
Improvement (33)
No Changes (406)
Hardware Overview |
|
@swift-ci please benchmark |
|
@swift-ci please test linux platform |
|
Running full benchmark, some of those regressions are notoriously noisy but you never know. |
|
Build failed |
|
Hmm ok that's a genuine linux failure rather than the spurious one this time. |
Build comment file:Optimized (O)Regression (10)
Improvement (13)
No Changes (435)
Unoptimized (Onone)Regression (8)
Improvement (51)
No Changes (399)
Hardware Overview |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke benchmark |
1 similar comment
|
@swift-ci please smoke benchmark |
Build comment file:Optimized (O)Regression (24)
Improvement (19)
No Changes (415)
Hardware Overview |
lancep
requested review from
moiseev,
milseman,
lorentey,
stephentyrone and
airspeedswift
|
This all seems reasonable to me, but then I didn't even know this existed =) |
lorentey
approved these changes
Jul 10, 2018
stdlib/public/core/ArrayShared.swift
Outdated
|
|
||
| _sanityCheck(headCount >= 0) | ||
| _sanityCheck(newCount >= 0) | ||
|
|
||
| let initializeNewElements = initializeNewElements ?? { ptr, count in |
There was a problem hiding this comment.
What if the closure parameter was non-optional, with this as the default value?
There was a problem hiding this comment.
It makes the function signature pretty gnarly but maybe it's worth it?
lorentey
reviewed
Jul 10, 2018
| _ dest: inout _ContiguousArrayBuffer<Element>, | ||
| _ headCount: Int, // Count of initial source elements to copy/move | ||
| _ newCount: Int, // Number of new elements to insert | ||
| _ initializeNewElements: Initializer | ||
| ) where | ||
| Initializer: _PointerFunction, |
There was a problem hiding this comment.
Idea for an alternative design: replace the closure parameter by returning the newly opened uninitialized gap as an UnsafeMutableBufferPointer, which the callee would be expected to fill in.
There was a problem hiding this comment.
Interesting idea! I think I lean more towards keeping the closure, I like scoping the pointer mutation to as small a scope as possible.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _PointerFunction protocol and related types are kind of weird and unnecessary.