Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Cleanup DefaultIndices, delete dead code #13952

Merged
merged 4 commits into from
Jan 15, 2018
Merged

[stdlib] Cleanup DefaultIndices, delete dead code #13952

merged 4 commits into from
Jan 15, 2018

Conversation

airspeedswift
Copy link
Member

Replace some uses of Default(Bidirectional|RandomAccess)Indices that I missed, plus one use of IndexDistance still in Foundation.

Delete unused internal_CollectionOf type.

Remove no-longer-needed gyb helper for generating DefaultIndices variants.

@airspeedswift
Copy link
Member Author

@parkera @phausler couple of minor Foundation cleanups in here.

Also reminds me I owe you a matching cleanup for corelibs equivalents of various things...

@airspeedswift
Copy link
Member Author

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented Jan 15, 2018

Foundation part LGTM.

@airspeedswift airspeedswift merged commit ca6c6b1 into swiftlang:master Jan 15, 2018
@airspeedswift airspeedswift deleted the cleanup-indices-existential branch January 15, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airspeedswift @parkera