Minor improvements to the Python linter #12079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it returned 0 in such a case, which is considered as a successful exit.
|
@swift-ci please python lint |
|
Going to manually squash and merge this @swift-ci please smoke test |
CodaFi
reviewed
Sep 23, 2017
utils/python_lint.py
Outdated
| python -m pip install flake8-import-order | ||
|
|
||
| For more help, see http://flake8.pycqa.org.""") | ||
| return flake8_result |
There was a problem hiding this comment.
You can keep the message, but it seems that our Linux bots lint gyb files and don’t have flake8 installed. Please keep the return value as is.
There was a problem hiding this comment.
Thank you for catching this with a smoke test.
I've reverted the change, and added a sticky note.
With this reverted, there are no functional changes. So the commit message for the squash could read: "Improve Python linter documentation".
|
@swift-ci please smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commit messages for details.