JUnit XML recorder should ignore warning issues #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
bug
stmontgomery
requested review from
grynspan,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
stmontgomery
commented
Feb 28, 2025
| let context = Event.Context(test: nil, testCase: nil, configuration: nil) | ||
|
|
||
| let recorder = Event.JUnitXMLRecorder { string in | ||
| if string.contains("<testsuite") { | ||
| #expect(string.contains(#"failures=1"#)) |
There was a problem hiding this comment.
This is a drive-by fix to the pre-existing test above the new one I added below: This one wasn't actually working, since no .runEnded event was recorded, so this callback wasn't happening. Once I fixed that I noticed a secondary issue, which is that the "failures=1" string was missing double quotes around the number 1.
grynspan
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
Event.JUnitXMLRecorderto ignoreIssueinstances whoseseverityis less than.error(such as.warning).Motivation:
The concept of issue severity was recently added in #931 (but was reverted and re-landed in #952), and that did not adjust the JUnit XML recorder logic. The JUnit XML schema we currently attempt to adhere to does not appear to have a way to represent non-fatal issues, so I think it would be best for now to ignore these issues.
Modifications:
Checklist: