Change the return types of test content accessors and add ExitTest.current.
#974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent`. This PR changes the signatures of the accessor functions for the test content metadata section so that we're not using underscored types. Instead, a `Test.Generator` type replaces `Test._Record` and the bare function type we were using for `Test` and `ExitTest` is promoted to (still experimental) API instead of hiding behind underscores. This change allows the types produced by accessor functions to always be nominal types, avoids the iffy substitution of `_Record` for `@Sendable () async -> Test` at runtime, and simplifies the internal `TestContent` protocol by eliminating the need for an associated type to stand in for the conforming type. This change leaves `ExitTest` as a nominal, but empty, type. I've added `ExitTest.current` to make it useful so that test code, especially libraries, can detect if it's running inside an exit test or not. I will separately update the exit test proposal PR to include this type and property.
grynspan
added
tools integration
grynspan
requested review from
SeanROlszewski,
briancroom,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
stmontgomery
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signatures of the accessor functions for the test content metadata section so that we're not using underscored types. Instead, a
Test.Generatortype replacesTest._Recordand the bare function type we were using forTestandExitTestis promoted to (still experimental) API instead of hiding behind underscores.This change allows the types produced by accessor functions to always be nominal types, avoids the iffy substitution of
_Recordfor@Sendable () async -> Testat runtime, and simplifies the internalTestContentprotocol by eliminating the need for an associated type to stand in for the conforming type.This change leaves
ExitTestas a nominal, but empty, type. I've addedExitTest.currentto make it useful so that test code, especially libraries, can detect if it's running inside an exit test or not. I will separately update the exit test proposal PR to include this type and property.Checklist: