build: restructure the installation location #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
SeanROlszewski,
briancroom,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
Member
Author
|
CC: @etcwilde |
Member
Author
|
@swift-ci please test |
etcwilde
reviewed
Feb 25, 2025
compnerd
force-pushed
the
installation
branch
from
3a31fcf to
eb4e0c7
Compare
Member
Author
|
@swift-ci please test |
compnerd
force-pushed
the
installation
branch
from
eb4e0c7 to
a945726
Compare
Member
Author
|
@swift-ci please test |
compnerd
force-pushed
the
installation
branch
from
a945726 to
422d8f5
Compare
Member
Author
|
@swift-ci please test |
compnerd
force-pushed
the
installation
branch
from
422d8f5 to
50ec4a6
Compare
Member
Author
|
@swift-ci please test |
compnerd
force-pushed
the
installation
branch
from
50ec4a6 to
c1003cd
Compare
Member
Author
|
@swift-ci please test |
Member
Author
|
With local testing: |
stmontgomery
approved these changes
Feb 28, 2025
Contributor
stmontgomery
left a comment
stmontgomery
left a comment
There was a problem hiding this comment.
I had one question about the CMP0157 policy change I just noticed, but otherwise this is looking good to me now
compnerd
force-pushed
the
installation
branch
from
c1003cd to
9ac5cd2
Compare
Member
Author
|
@swift-ci please test |
2 tasks
compnerd
force-pushed
the
installation
branch
from
9ac5cd2 to
e418145
Compare
2 tasks
stmontgomery
approved these changes
Mar 4, 2025
Contributor
stmontgomery
left a comment
stmontgomery
left a comment
There was a problem hiding this comment.
LGTM now, feel free to merge!
Clean up some of the module property handling to be more declarative. This reduces the operations that are being done on targets in favour of defaults. Adopt the latest best practices for handling module installation. Introduce the new `SwiftTesting_INSTALL_NESTED_SUBDIR` option to allow installation into platform/architecture subdirectory allowing multi-architecture installations for platforms like Windows and Android. This is currently opt-in and requires a newer toolchain (something within the last ~2w) to detect the defaults. The values can be overridden by the user if desired.
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some of the module property handling to be more declarative. This reduces the operations that are being done on targets in favour of defaults.
Adopt the latest best practices for handling module installation. Introduce the new
SwiftTesting_INSTALL_NESTED_SUBDIRoption to allow installation into platform/architecture subdirectory allowing multi-architecture installations for platforms like Windows and Android. This is currently opt-in and requires a newer toolchain (something within the last ~2w) to detect the defaults. The values can be overridden by the user if desired.