Declare a package name for CMake builds and remove @_spi(ForSwiftTestingOnly) #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
enhancement
stmontgomery
requested review from
SeanROlszewski,
briancroom,
grynspan and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
grynspan
reviewed
Feb 12, 2025
Sources/Overlays/_Testing_CoreGraphics/Attachments/ImageAttachmentError.swift
Outdated
Show resolved
Hide resolved
grynspan
reviewed
Feb 12, 2025
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS |
grynspan
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes usage of
@_spi(ForSwiftTestingOnly)throughout the codebase and adjusts the CMake build rules to allow adoption of Swift'spackageaccess level. The technical constraints which prevented adopting that feature have been resolved.Checklist: