Add a (internal-only) CustomIssueRepresentable protocol.
#945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a (for now internal-only) protocol that lets us transform arbitrary errors to arbitrary issues (rather than always emitting them as `.errorCaught`). This protocol replaces the special-casing we were doing for `SystemError` and `APIMisuseError`. This change also causes us to emit an API misuse issue if a developer passes an error of type `ExpectationFailedError` to `Issue.record()` as we can reasonably assume that such an error was already recorded correctly as `.expectationFailed`.
grynspan
added
enhancement
grynspan
requested review from
SeanROlszewski,
briancroom,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci test |
Co-authored-by: Stuart Montgomery <smontgomery@apple.com>
Co-authored-by: Stuart Montgomery <smontgomery@apple.com>
Contributor
Author
|
@swift-ci test |
stmontgomery
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a (for now internal-only) protocol that lets us transform arbitrary errors to arbitrary issues (rather than always emitting them as
.errorCaught). This protocol replaces the special-casing we were doing forSystemErrorandAPIMisuseError.This change also causes us to emit an API misuse issue if a developer passes an error of type
ExpectationFailedErrortoIssue.record()as we can reasonably assume that such an error was already recorded correctly as.expectationFailed.Checklist: