Skip to content

Fix statically-linked platforms building new test content discovery code. #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix statically-linked platforms building new test content discovery code. #897

merged 1 commit into from
Jan 7, 2025

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 7, 2025 •
edited
Loading

This PR fixes an undefined symbol error for SWTTestContentSectionBounds when building for statically-linked platforms. This issue appears to only occur with CMake and is (I think) a quirk of that build system.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix statically-linked platforms building new test content discovery c…
8472582 
…ode.

This PR fixes an undefined symbol error for `SWTTestContentSectionBounds` when
building for statically-linked platforms. This issue appears to only occur with
CMake and is (I think) a quirk of that build system.
@grynspan grynspan added bug 🪲 Something isn't working workaround Workaround for an issue in another component (may need to revert later) wasi/wasm 🧭 WebAssembly support build 🧱 Affects the project's build configuration or process labels Jan 7, 2025
@grynspan grynspan self-assigned this Jan 7, 2025
@grynspan grynspan added this to the Swift 6.x milestone Jan 7, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Jan 7, 2025

@swift-ci test

@grynspan grynspan merged commit aee0821 into main Jan 7, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/fix-static-linked-platforms branch January 7, 2025 23:23
@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

Assignees

@grynspan grynspan

Labels

bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process discovery 🔎 test content discovery wasi/wasm 🧭 WebAssembly support workaround Workaround for an issue in another component (may need to revert later)

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@grynspan @stmontgomery