Generalize time types. #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
grynspan
force-pushed
the
jgrynspan/generalize-time-types
branch
from
1d6041e to
295afc1
Compare
Contributor
Author
|
@swift-ci please test |
briancroom
approved these changes
Oct 25, 2023
dennisweissmann
approved these changes
Oct 25, 2023
This PR generalizes the storage of timestamps and durations using a new internal-only `TimeValue` type. This type represents any "seconds and subseconds" value such as a `timespec`, `SuspendingClock.Instant`, `Duration`, etc. This type allows us to simplify the story for storing, handling, encoding, and decoding time values. Whereas previously we had a lot of conditionalized code like: ```swift #if SWT_TARGET_OS_APPLE doSomething(uptime) #else doSomethingSimilar(suspending) #endif ``` We can now generally use the same code path for both.
grynspan
force-pushed
the
jgrynspan/generalize-time-types
branch
from
295afc1 to
d7d55cc
Compare
Contributor
Author
|
@swift-ci please test |
stmontgomery
added a commit
to stmontgomery/swift-testing
that referenced
this pull request
Oct 27, 2023
This extends the `TimeValue` type added in swiftlang#83 by allowing conversion to `timespec`. It then adopts that in a couple places to ensure consistency.
stmontgomery
added a commit
that referenced
this pull request
Oct 27, 2023
This extends the `TimeValue` type added in #83 by allowing conversion to `timespec`. It then adopts that in a couple places to ensure consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the storage of timestamps and durations using a new internal-only
TimeValuetype. This type represents any "seconds and subseconds" value such as atimespec,SuspendingClock.Instant,Duration, etc.This type allows us to simplify the story for storing, handling, encoding, and decoding time values. Whereas previously we had a lot of conditionalized code like:
We can now generally use the same code path for both.