Skip to content

Conversation

@stmontgomery
Copy link
Contributor

This fixes an oversight in a helper function in the project’s CMake rules: _swift_testing_install_target() has a hard-coded reference to the target named ”Testing” but it should instead refer to whatever target was passed in via the module argument to the function.

Discovered while working on #825.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process labels Nov 19, 2024
@stmontgomery stmontgomery self-assigned this Nov 19, 2024
@stmontgomery stmontgomery added this to the Swift 6.1 milestone Nov 19, 2024
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery stmontgomery merged commit f2ea716 into swiftlang:main Nov 19, 2024
3 checks passed
@stmontgomery stmontgomery deleted the swift-testing branch November 19, 2024 04:21
@grynspan grynspan modified the milestones: Swift 6.1, Swift 6.2 Nov 19, 2024
@stmontgomery stmontgomery added the self-reviewed PR was self-reviewed by a code owner label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process self-reviewed PR was self-reviewed by a code owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants