Add the ability to filter tests by tag using an envvar. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a follow-on to #77. It adds the ability to filter tests to just the ones that contain a given tag using an environment variable. As before, `swift test --filter` is unaware of swift-testing, so we need a temporary solution until such time as `swift test` is taught about us. To try it out: ``` SWT_SELECTED_TAGS='trait' swift test ``` Will run only those tests with the `"trait"` tag. If both `"SWT_SELECTED_TAGS""` and `"SWT_SELECTED_TEST_IDS"` are specified, a test must have (at least one of) the given tags _and_ be selected by ID. Whether or not this is the right way to combine these environment variables is, to be polite, probably uninteresting since this is not meant to be a permanent solution. This change also implements `==` and `hash(into:)` on `Tag` as they were previously synthesized which would cause them to consider the internal `sourceCode` property, which was not intentional.
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
briancroom
approved these changes
Oct 24, 2023
| for test in tests { | ||
| let idComponents = test.id.keyPathRepresentation | ||
| testGraph.insertValue(test, at: idComponents) | ||
| actionGraph.insertValue(.run, at: idComponents, intermediateValue: .run) |
Contributor
There was a problem hiding this comment.
Moving the where ... clause here will cause the actionGraph to always be updated, even if some of those tests are later filtered out. Does something else later on cause the corresponding nodes in that graph to be pruned?
Contributor
Author
There was a problem hiding this comment.
Yes, immediately below we prune them out (after applying traits recursively) on line 173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to #77. It adds the ability to filter tests to just the ones that contain a given tag using an environment variable. As before,
swift test --filteris unaware of swift-testing, so we need a temporary solution until such time asswift testis taught about us.To try it out:
Will run only those tests with the
"trait"tag.If both
"SWT_SELECTED_TAGS""and"SWT_SELECTED_TEST_IDS"are specified, a test must have (at least one of) the given tags and be selected by ID. Whether or not this is the right way to combine these environment variables is, to be polite, probably uninteresting since this is not meant to be a permanent solution.This change also implements
==andhash(into:)onTagas they were previously synthesized which would cause them to consider the internalsourceCodeproperty, which was not intentional.