Report a skipped event for parameterized tests with no cases #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a parameterized test's argument list is empty, a "skip" event is a better reflection of the fact that the test function doesn't actually get executed.
briancroom
requested review from
SeanROlszewski,
dennisweissmann,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
dennisweissmann
approved these changes
Jul 24, 2024
Contributor
Author
|
@swift-ci please test |
grynspan
requested changes
Jul 24, 2024
Tests/TestingTests/RunnerTests.swift
Outdated
| let testSkipped = expectation(description: "Test was skipped") | ||
| var configuration = Configuration() | ||
| configuration.eventHandler = { event, _ in | ||
| if case .testSkipped(_) = event.kind { |
Contributor
There was a problem hiding this comment.
Suggested change
| if case .testSkipped(_) = event.kind { | |
| if case .testSkipped = event.kind { |
| } | ||
|
|
||
| // If the test is parameterized but has no cases, mark it as skipped. | ||
| if case .run = action, test.isParameterized, test.testCases?.lazy.first(where: { _ in true }) == nil { |
Contributor
There was a problem hiding this comment.
Suggested change
| if case .run = action, test.isParameterized, test.testCases?.lazy.first(where: { _ in true }) == nil { | |
| if case .run = action, test.isParameterized, test.testCases?.first(where: { _ in true }) == nil { |
Contributor
Author
|
@swift-ci please test |
grynspan
reviewed
Jul 24, 2024
| } | ||
|
|
||
| // If the test is parameterized but has no cases, mark it as skipped. | ||
| if case .run = action, test.isParameterized, test.testCases?.first(where: { _ in true }) == nil { |
Contributor
There was a problem hiding this comment.
We could also express this as:
if case .run = action, let testCases = test.testCases, testCases.first(where: { _ in true }) == nil {Which might be slightly more efficient.
Contributor
Author
|
@swift-ci please test |
grynspan
approved these changes
Jul 24, 2024
Contributor
|
Merging on Brian's behalf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a parameterized test's argument list is empty, a "skip" event is a better reflection of the fact that the test function doesn't actually get executed.
With this change, a
.testSkippedevent will get posted for such tests, instead of a.testStarted+.testEndedevent pair.This also means that the following tests will be reported very similarly (with just a different comment on the
SkipInfo):Checklist: