Check availability before calling _mangledTypeName(_:).
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently call the stdlib SPI function `_mangledTypeName(_:)` in a few spots (pending availability of a more general reflection API.) This function needs availability checks to be used on Apple platforms other than macOS.
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
stmontgomery
approved these changes
Oct 11, 2023
Contributor
Author
|
@swift-ci please test |
briancroom
approved these changes
Oct 11, 2023
Contributor
Author
|
Manually tested at-desk on macOS 14 and Ubuntu 22. A compiler bug in the latest toolchain prevents testing in CI. Team has approved merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently call the stdlib SPI function
_mangledTypeName(_:)in a few spots (pending availability of a more general reflection API.) This function needs availability checks to be used on Apple platforms other than macOS.