Switch from unsafeFlags to enableExperimentalFeature to enable strict concurrency checking #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… concurrency checking
stmontgomery
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
grynspan and
suzannaratcliff
as code owners
|
@swift-ci please test |
dennisweissmann
approved these changes
Oct 9, 2023
briancroom
approved these changes
Oct 9, 2023
grynspan
approved these changes
Oct 10, 2023
|
Compiler crash:
While lowering |
|
@swift-ci please test |
|
Manually tested at-desk on macOS 14 and Ubuntu 22. A compiler bug in the latest toolchain prevents testing in CI. Team has approved merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one of our usages of
.unsafeFlagsin favor of.enableExperimentalFeature, which is helpful since.unsafeFlagscannot be safely used by clients (except when the package is local or using a branch for its dependency).