Add an experimental CLI argument for passing a configuration value as JSON. #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JSON. This PR adds a new CLI argument, `--experimental-configuration-path`, which can be used to specify the path to a file containing an instance of `__CommandLineArguments_v0` encoded as JSON. `/dev/stdin` or a named pipe can be specified if desired. Changes to SwiftPM will be needed to support passing this argument all the way through from `swift test`.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
commented
May 7, 2024
| if args.contains("--list-tests") { | ||
| result.listTests = true | ||
| return result // do not bother parsing the other arguments |
There was a problem hiding this comment.
This early return prevented saying --list-tests --verbose for example. Ditch it while I'm here.
plemarquand
reviewed
May 7, 2024
|
@swift-ci please test |
dennisweissmann
approved these changes
May 7, 2024
plemarquand
approved these changes
May 7, 2024
stmontgomery
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CLI argument,
--experimental-configuration-path, which can be used to specify the path to a file containing an instance of__CommandLineArguments_v0encoded as JSON./dev/stdinor a named pipe can be specified if desired.Changes to SwiftPM will be needed to support passing this argument all the way through from
swift test.Checklist: