Skip to content

Improve type-checking time of listTestsForSwiftPM #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Improve type-checking time of listTestsForSwiftPM #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/Testing/Running/EntryPoint.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ func listTestsForSwiftPM(_ tests: some Sequence<Test>) -> [String] {
// Group tests by the name components of the tests' IDs. If the name
// components of two tests' IDs are ambiguous, present their source locations
// to disambiguate.
return Dictionary(
let initialGroups = Dictionary(
grouping: tests.lazy.map(\.id),
by: \.nameComponents
).values.lazy
.map { ($0, isAmbiguous: $0.count > 1) }
.flatMap { testIDs, isAmbiguous in

// This operation is split to improve type-checking performance.
return initialGroups.flatMap { testIDs, isAmbiguous in
testIDs.lazy
.map { testID in
if !isAmbiguous, testID.sourceLocation != nil {
Expand Down