Capture the current working directory early on OpenBSD. #1388
+84
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some OpenBSD-specific code to capture the current working directory as early as possible. We then use that directory when argv[0] appears to be a relative path so that the following incantation works correctly: ```sh ./.build/debug/myPackageTests.xctest --testing-library swift-testing ``` This logic is not necessary on other platforms because they all provide a way to get the path to the current executable. OpenBSD has no such API.
grynspan
added
the
workaround
grynspan
requested review from
jerryjrchen and
suzannaratcliff
as code owners
grynspan
added
exit-tests
|
@3405691582 please take a look! |
|
Discussed with @3405691582 in DMs; will need to move the constructor function down to C++ (darn) to ensure it compiles correctly on at least some 6.3-dev toolchains. |
stmontgomery
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some OpenBSD-specific code to capture the current working directory as early as possible. We then use that directory when argv[0] appears to be a relative path so that the following incantation works correctly:
This logic is not necessary on other platforms because they all provide a way to get the path to the current executable. OpenBSD has no such API.
Resolves #1348.
Checklist: