Testing: fix Windows specific code for application data #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
ejvaughan,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
grynspan
reviewed
Nov 13, 2023
The parameter is expected to be `KNOWNFOLDERID` which is a `Optional<UnsafePointer<GUID>>`. Additionally, correct the spelling of `NULL` to `nil`. This allows the target to build on Windows.
Member
Author
|
@swift-ci please test |
grynspan
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter is expected to be
KNOWNFOLDERIDwhich is aOptional<UnsafePointer<GUID>>. Additionally, correct the spelling ofNULLtonil. This allows the target to build on Windows.