Add signal handler for SIGABRT_COMPAT on Windows.
#1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special-case signal handling implemented for Windows doesn't currently set a handler for `SIGABRT_COMPAT` (which is a synonym of `SIGABRT` with a different value.) This PR adds it to the list of signals we install handlers for.
grynspan
added
bug
grynspan
requested review from
SeanROlszewski,
briancroom,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci test |
briancroom
approved these changes
Apr 7, 2025
stmontgomery
approved these changes
Apr 7, 2025
grynspan
added a commit
that referenced
this pull request
Apr 7, 2025
The special-case signal handling implemented for Windows doesn't currently set a handler for `SIGABRT_COMPAT` (which is a synonym of `SIGABRT` with a different value.) This PR adds it to the list of signals we install handlers for. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Apr 8, 2025
- **Explanation**: Make sure all public signals on Windows are handled correctly in exit tests. - **Scope**: Windows exit tests - **Issues**: N/A - **Original PRs**: #1056 - **Risk**: Low - **Testing**: CI jobs - **Reviewers**: @briancroom @stmontgomery @compnerd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special-case signal handling implemented for Windows doesn't currently set a handler for
SIGABRT_COMPAT(which is a synonym ofSIGABRTwith a different value.) This PR adds it to the list of signals we install handlers for.Checklist: