Miscellaneous bookkeeping/cleanup of _TestDiscovery.
#1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has a few minor changes: - The default implementation of `DiscoverableAsTestContent._testContentTypeNameHint` is not present if `SWT_NO_LEGACY_TEST_DISCOVERY` is defined; - Fixed the precondition in `TestContentKind.init(stringLiteral:)` so it doesn't call `utf8CodeUnitCount` on single-character static strings; - The implementation of `TestContentKind._fourCCValue` uses `isprint()` to check if the kind value looks like a FourCC rather than calling ICU-based functions; - Fixed a type in a comment on `SectionBounds.Kind.segmentAndSectionName`; and - Simplified the implementation of `TestContentKind.commentRepresentation` (in the macro target).
grynspan
added
bug
grynspan
requested review from
SeanROlszewski,
briancroom,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci test |
briancroom
approved these changes
Apr 7, 2025
grynspan
added a commit
that referenced
this pull request
Apr 7, 2025
This PR has a few minor changes: - The default implementation of `DiscoverableAsTestContent._testContentTypeNameHint` is not present if `SWT_NO_LEGACY_TEST_DISCOVERY` is defined; - Fixed the precondition in `TestContentKind.init(stringLiteral:)` so it doesn't call `utf8CodeUnitCount` on single-character static strings; - The implementation of `TestContentKind._fourCCValue` uses `isprint()` to check if the kind value looks like a FourCC rather than calling ICU-based functions; - Fixed a type in a comment on `SectionBounds.Kind.segmentAndSectionName`; and - Simplified the implementation of `TestContentKind.commentRepresentation` (in the macro target). ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Apr 8, 2025
- **Explanation**: Some minor code cleanup in/around the `_TestDiscovery` module. - **Scope**: Internal only - **Issues**: N/A - **Original PRs**: #1055 - **Risk**: Low (nothing obvious) - **Testing**: The usual CI jobs. - **Reviewers**: @briancroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few minor changes:
DiscoverableAsTestContent._testContentTypeNameHintis not present ifSWT_NO_LEGACY_TEST_DISCOVERYis defined;TestContentKind.init(stringLiteral:)so it doesn't callutf8CodeUnitCounton single-character static strings;TestContentKind._fourCCValueusesisprint()to check if the kind value looks like a FourCC rather than calling ICU-based functions;SectionBounds.Kind.segmentAndSectionName; andTestContentKind.commentRepresentation(in the macro target).Checklist: