Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: account for spaces in the toolchain #1030

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

compnerd
Copy link
Member

If the macro library path contains a space, the invocation will improperly truncate it. Account for this eventuality.

If the macro library path contains a space, the invocation will
improperly truncate it. Account for this eventuality.
@compnerd
Copy link
Member Author

@swift-ci please test

@grynspan grynspan added bug Something isn't working windows 🪟 Windows support build Affects the project's build configuration or process labels Mar 19, 2025
Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it contains quote marks? 🧌

@grynspan grynspan added this to the Swift 6.2 milestone Mar 19, 2025
@compnerd compnerd merged commit e242d3e into swiftlang:main Mar 19, 2025
3 checks passed
@compnerd compnerd deleted the we-need-some-space branch March 19, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Affects the project's build configuration or process windows 🪟 Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants