Skip to content

Adjust a timing-sensitive TimeLimitTrait test to avoid flakiness in CI #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Adjust a timing-sensitive TimeLimitTrait test to avoid flakiness in CI #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Tests/TestingTests/Traits/TimeLimitTraitTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,17 @@ struct TimeLimitTraitTests {
await withTaskGroup(of: Void.self) { taskGroup in
taskGroup.addTask {
await Test {
try await Test.Clock.sleep(for: .seconds(60))
try await Test.Clock.sleep(for: .seconds(60) * 60)
}.run()
}
taskGroup.cancelAll()
}
}
#expect(timeAwaited < .seconds(5)) // less than the 60 second sleep

// Expect that the time awaited is significantly less than the duration of
// the sleep above. To avoid flakiness in CI, allow for a somewhat long
// wait, but still much less than the full sleep duration.
#expect(timeAwaited < .seconds(60))
}

@available(_clockAPI, *)
Expand Down