build: avoid doubly nesting the swift module #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always install the swift module into the platform directory. The additional nesting is not required.
compnerd
requested review from
SeanROlszewski,
briancroom,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
Member
Author
|
@swift-ci please test |
grynspan
added
bug
Contributor
|
Is this broken on specific platforms? |
Member
Author
|
It is broken on all platforms, except hidden by the fact that it is behind the disabled by default option of |
stmontgomery
approved these changes
Mar 14, 2025
Contributor
|
@compnerd Can you do a cross-repo build and ensure both smoke test and toolchain builds succeed? |
Contributor
|
Please squash when you merge! |
This was referenced Mar 14, 2025
Member
Author
|
Kicked off some tests at swiftlang/swift#65907 |
Member
Author
|
All tests (smoke test Linux, macOS, Windows & build toolchain Linux, macOS, Windows) except Windows Testing passed. The Windows Toolchain build succeeded, and a second run at swiftlang/swift#79932 passed. I'm going to merge this as all the builds seem to have passed and the one failure is a flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always install the swift module into the platform directory. The additional nesting is not required.