Skip to content

Don't emit @_section attributes unless the macro target has SymbolLinkageMarkers. #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

Don't emit @_section attributes unless the macro target has SymbolLinkageMarkers. #1018

merged 1 commit into from
Mar 12, 2025

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Mar 12, 2025 •
edited
Loading

This PR suppresses our use of @_section and @_used unless the macro target is built with SymbolLinkageMarkers enabled.

Resolves rdar://146819169.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Don't emit @_section attributes unless the macro target has `Symbol…
e248587 
…LinkageMarkers`.

This PR suppresses our use of `@_section` and `@_used` unless the macro target
is built with `SymbolLinkageMarkers` enabled.

Resolves rdar://146819169.
@grynspan grynspan added tools integration 🛠️ Integration of swift-testing into tools/IDEs build 🧱 Affects the project's build configuration or process macros 🔭 Related to Swift macros such as @Test or #expect labels Mar 12, 2025
@grynspan grynspan added this to the Swift 6.2 milestone Mar 12, 2025
@grynspan grynspan self-assigned this Mar 12, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Mar 12, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Mar 12, 2025

@stmontgomery I think you were thinking we'd do this :)

@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
@grynspan grynspan merged commit 0018a42 into main Mar 12, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/no-section-attribute-without-SymbolLinkageMarkers branch March 12, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briancroom briancroom briancroom approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

Assignees

@grynspan grynspan

Labels

build 🧱 Affects the project's build configuration or process discovery 🔎 test content discovery macros 🔭 Related to Swift macros such as @Test or #expect tools integration 🛠️ Integration of swift-testing into tools/IDEs

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@grynspan @briancroom