[CMake] Set CMP0157 to OLD when targeting Android with the Windows toolchain #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weliveindetail
requested review from
stmontgomery,
grynspan,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@compnerd Would you please help review? |
|
@swift-ci test |
finagolfin
approved these changes
Mar 10, 2025
|
Not a committer but LGTM |
|
Waiting for Saleem to sign off, then we can squash and merge. |
|
No need, he didn't comment on the linked Foundation pull either, and this is a tiny pull that his TBC colleagues @weliveindetail and @Steelskin need and won't break anything. If you're okay with it, @grynspan, please go ahead and merge. |
grynspan
approved these changes
Mar 10, 2025
|
Alrighty, it's clear the change should only impact Android, so… merging. |
|
Thanks for moving on with this so quickly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no early swift-driver build for the Windows toolchain. As a result, swift-testing fails to build properly when CMP0157 is set to NEW due to object files not being generated.
This sets CMP0157 to OLD when targeting Android with the Windows toolchain until the early swift-driver is available on Windows. This is analog to swiftlang/swift-corelibs-foundation#5180
Checklist: