Add ConditionTraitTests to cover the Swift 6.0 compiler issue for custom trait + closure + macro #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Ye
requested review from
SeanROlszewski,
briancroom,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
Kyle-Ye
force-pushed
the
optimize/kyle/closure_test_case
branch
from
f676fe7 to
381426b
Compare
Kyle-Ye
commented
Mar 10, 2025
Contributor
|
@swift-ci please test |
Contributor
|
@swift-ci please test Linux |
grynspan
added
workaround
Kyle-Ye
force-pushed
the
optimize/kyle/closure_test_case
branch
from
381426b to
0301161
Compare
…tom trait + closure + macro See swiftlang#1006 (comment)
Kyle-Ye
force-pushed
the
optimize/kyle/closure_test_case
branch
from
0301161 to
7d33b87
Compare
Contributor
|
@swift-ci please test |
stmontgomery
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1006 (comment)
Motivation:
Add test case for avoid regression.
Modifications:
Add ConditionTraitTests test case to cover it
Result:
If will cause a compiler crash for Swift 6.0 compiler.
And it should work fine on the latest Swift 6.1 compiler.
Checklist: