Skip to content

[CMake] Fix quote in a generator expression #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[CMake] Fix quote in a generator expression #1002

merged 1 commit into from
Mar 7, 2025

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Mar 7, 2025 •
edited by grynspan
Loading

Fix failures

https://ci.swift.org/job/oss-swift-RA-linux-ubuntu-22_04-long-test/8432/

-- Installing: /home/build-user/build/buildbot_incremental/toolchain-linux-x86_64/usr/lib/swift/linux/lib_Testing_Foundation.so
-- Set non-toolchain portion of runtime path of "/home/build-user/build/buildbot_incremental/toolchain-linux-x86_64/usr/lib/swift/linux/lib_Testing_Foundation.so" to ""$ORIGIN""

...

/home/build-user/build/buildbot_incremental/swiftfoundationtests-linux-x86_64/x86_64-unknown-linux-gnu/release/swift-foundationPackageTests.xctest: error while loading shared libraries: libFoundationEssentials.so: cannot open shared object file: No such file or directory

Resolves rdar://146327019.

@rintaro
Copy link
Member Author

rintaro commented Mar 7, 2025

@swift-ci Please test

@rintaro rintaro mentioned this pull request Mar 7, 2025
Merged
@tshortli tshortli mentioned this pull request Mar 7, 2025
Merged
This was referenced Mar 7, 2025
Merged
Merged
@meg-gupta meg-gupta mentioned this pull request Mar 7, 2025
Merged
@grynspan grynspan added bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process labels Mar 7, 2025
@grynspan grynspan added this to the Swift 6.x milestone Mar 7, 2025
@rintaro rintaro merged commit d408571 into swiftlang:main Mar 7, 2025
3 checks passed
@rintaro rintaro deleted the generator-expr-quote branch March 7, 2025 12:06
stmontgomery
stmontgomery reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery left review comments

@jakepetroules jakepetroules jakepetroules approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

Assignees

@rintaro rintaro

Labels

bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rintaro @stmontgomery @jakepetroules @grynspan