Adjust Task.immediate use so we can bring back Swift 6.1 CI until 6.2 is fixed #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We'd have to platform guard the Task.immediate for the time being as a workaround perhaps... It's not great not having linux CI for all those samples so I'm looking at potential workarounds until 6.2 is fixed. |
ktoso
force-pushed
the
wip-try-6.1-linux
branch
from
7651cce to
77ae522
Compare
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lost ability to CI with 6.1 since we introduced Task.immediate in the asynchronous func support.
We need 6.1 support because 6.1.3 has a SwiftPM fix that prevents random build crashes.
6.2 has missed this fix and will only get it fixed in next releases: swiftlang/swift-package-manager#9314
Frequent crashes in LLBuildProgressTracker while building swift-java on linux and swift.This #if guards code using Task.immediate, adjusts the tests, and also brings back 6.1 CI.
Failures with 6.2 are expected and will continue for the time being.