Docs/wrap command #368
Closed
Docs/wrap command #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hmm sorry but this change seems to just be adding two comments while reformating a bunch more... I don't think this is good as is. We do need to enable the swift-format validation -- previously it was hanging but maybe 6.2 will be working well again, I'll follow up on it #371 -- If you want to document things perhaps focus on JavaKit APIs or even better some text in |
Contributor
Author
|
Thank you for taking the time to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Adding documentation on functions in WrapCommand.swift
Summary
Providing a short definition about the function and parameters on generateWrappers(...) and effectiveSwiftModuleURL
Type of Change
Adding documentation
p.s.: I feel like I am messing up the formatting :/