-
Notifications
You must be signed in to change notification settings - Fork 67
Open
Labels
bugSomething isn't workingSomething isn't workingfeature:wrap-javagood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Due to dependencies behaving weirdly in plugins the JavaKit dependency was not pulled unless more things were spelled out explicitly...
This resulted in a generated file like:
@JavaClass("org.apache.commons.io.FilenameUtils")
open class FilenameUtils {
@JavaMethod
@_nonoverride public convenience init(environment: JNIEnvironment? = nil)
}
which will fail to compile because we need the:
@JavaClass("org.apache.commons.io.FilenameUtils")
open class FilenameUtils: JavaObject {
@JavaMethod
@_nonoverride public convenience init(environment: JNIEnvironment? = nil)
}
form.
If we're ever generating code and we're missing JavaObject we should just immediately crash rather than hide the error futher along the build as it can be hard to diagnose what actually went wrong -- but it was a missing dependency on the swift-java file that declared java.lang.object.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingfeature:wrap-javagood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed