Add .count and .date properties to Calendar.RecurrenceRule.End
#888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hristost
force-pushed
the
hs/calendar-recurrence-rule-update-end-impl
branch
2 times, most recently
from
49879f1 to
348227a
Compare
|
@swift-ci run |
|
@swift-ci please test |
`Calendar.RecurrenceRule.End` is de-facto an enum, but has been implemented as a struct so we can more easily extend it in the future without breaking ABI. Sadly the current API only provides a way to construct the struct, and does not let us introspect the associated values. This change adds a couple read-only properties to the struct to address this. While at it, we also make the struct conform to `CustomStringConvertible`, so it doesn't leak implementation details when it's printed in the debugger.
hristost
force-pushed
the
hs/calendar-recurrence-rule-update-end-impl
branch
from
348227a to
f0af6cf
Compare
|
@swift-ci please test |
jmschonfeld
approved these changes
Sep 13, 2024
|
@swift-ci please test |
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…wiftlang#888) `Calendar.RecurrenceRule.End` is de-facto an enum, but has been implemented as a struct so we can more easily extend it in the future without breaking ABI. Sadly the current API only provides a way to construct the struct, and does not let us introspect the associated values. This change adds a couple read-only properties to the struct to address this. While at it, we also make the struct conform to `CustomStringConvertible`, so it doesn't leak implementation details when it's printed in the debugger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar.RecurrenceRule.Endis de-facto an enum, but has been implemented as a struct so we can more easily extend it in the future without breaking ABI. Sadly the current API only provides a way to construct the struct, and does not let us introspect the associated values. This change adds a couple read-only properties to the struct to address this.