Skip to content

FoundationEssentials: relax error handling for SHGetFolderPath #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

FoundationEssentials: relax error handling for SHGetFolderPath #676

merged 1 commit into from
Jun 12, 2024

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jun 12, 2024

When running in CI, we would see failures due to the environment variables being changed. This relaxes the precondition to allow the test failure to propagate.

@compnerd compnerd requested a review from jmschonfeld June 12, 2024 16:53
@compnerd
Copy link
Member Author

compnerd commented Jun 12, 2024

@swift-ci please test Windows platform

@compnerd compnerd requested a review from parkera June 12, 2024 16:53
@jmschonfeld
Copy link
Contributor

jmschonfeld commented Jun 12, 2024 

Test Case 'FileManagerTests.testSearchPaths' started at 2024-06-12 17:11:56.556

C:\source\swift-foundation\Tests\FoundationEssentialsTests\FileManager\FileManagerTests.swift:718: error: FileManagerTests.testSearchPaths : XCTAssertEqual failed: ("false") is not equal to ("true") - Directory picturesDirectory produced an unexpected number of paths (expected to exist: true, produced: [])

Test Case 'FileManagerTests.testSearchPaths' failed (0.015 seconds)

Looks like we should update the unit test to account for this - looks like the pictures directory doesn't exist on CI

@compnerd
Copy link
Member Author

compnerd commented Jun 12, 2024

@swift-ci please test

@compnerd
FoundationEssentials: relax error handling for SHGetFolderPath
5aefd3e 
When running in CI, we would see failures due to the environment
variables being changed. This relaxes the precondition to allow the test
failure to propagate.
@compnerd
Copy link
Member Author

compnerd commented Jun 12, 2024

@swift-ci please test

@compnerd compnerd requested a review from jmschonfeld June 12, 2024 18:27
@jmschonfeld jmschonfeld merged commit 142f409 into swiftlang:main Jun 12, 2024
@compnerd compnerd deleted the failure branch June 12, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmschonfeld jmschonfeld jmschonfeld approved these changes

@parkera parkera Awaiting requested review from parkera

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@compnerd @jmschonfeld