Use a CShim to avoid an unescapable warning about using mktemp #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jmschonfeld
reviewed
Mar 20, 2024
parkera
force-pushed
the
parkera/avoid_mktemp_warning
branch
from
94cd4a2 to
5aedca6
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Huh, the Linux one picked up yesterday's toolchain |
|
@swift-ci please test Linux |
|
@swift-ci please clean test Linux |
jmschonfeld
approved these changes
Mar 21, 2024
|
@swift-ci please test Linux |
|
Well, we got the new toolchain on Linux, but |
|
@swift-ci test |
iCharlesHu
approved these changes
Apr 11, 2024
parkera
force-pushed
the
parkera/avoid_mktemp_warning
branch
from
5aedca6 to
bf1138b
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We work around the security issue with
mktempby checking for the existence of a conflict and retrying if necessary. The comment already in the source code explains why we can't usemkstemp. To avoid this warning appearing for every client of the package, work around it by adding a C shim before we call it.