[Gregorian Calendar] Implement weekend-related functions #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
parkera
reviewed
Jan 4, 2024
| var cease: UInt32? | ||
|
|
||
| var status = U_ZERO_ERROR | ||
| let cal = ucal_open(nil, 0, identifier, UCAL_DEFAULT, &status) |
Contributor
There was a problem hiding this comment.
Is it going to be more expensive (CPU time) to open and close the calendar here, vs on Calendar_ICU where we reuse the ucalendar we already had?
I don't think it is a showstopper, because this makes a lot more sense, but we should be aware.
Contributor
Author
There was a problem hiding this comment.
I don't see an obvious performance regression. This value is cached inside this _LocaleICU instance, so we'd only call ucal_open once per Calendar-Locale combination. Since we're also caching locale by its identifier, we'd be fetching from the cache most of the time.
parkera
approved these changes
Jan 5, 2024
Calendar's weekend support requires the following functions: 1. `isDateInWeekend`: answers whether a given date is in weekend 2. `weekendRange`: function that returns the days and times of the weekend This implements the first. The second one, weekend range, is in fact related to calendar's locale rather than calendar itself. Move it over to `_LocaleProtocol` and have locale handle it.
itingliu
force-pushed
the
gregorian-calendar-weekend
branch
from
32aa198 to
55b9dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar's weekend support requires the following functions:
isDateInWeekend: answers whether a given date is in weekendweekendRange: function that returns the days and times of the weekendThis implements the first. The second one, weekend range, is in fact related to calendar's locale rather than calendar itself. Move it over to
_LocaleProtocoland have locale handle it.