-
Notifications
You must be signed in to change notification settings - Fork 207
Generalize ContiguousBytes to be noncopyable and nonescapable for spans #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
9760ccc
fd55250
6f4d2b9
d71aef0
892f17b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,14 +15,55 @@ | |
| /// Indicates that the conforming type is a contiguous collection of raw bytes | ||
| /// whose underlying storage is directly accessible by withUnsafeBytes. | ||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| public protocol ContiguousBytes { | ||
| public protocol ContiguousBytes: ~Escapable, ~Copyable { | ||
| #if !hasFeature(Embedded) | ||
| /// Calls the given closure with the contents of underlying storage. | ||
| /// | ||
| /// - note: Calling `withUnsafeBytes` multiple times does not guarantee that | ||
| /// the same buffer pointer will be passed in every time. | ||
| /// - warning: The buffer argument to the body should not be stored or used | ||
| /// outside of the lifetime of the call to the closure. | ||
| func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R | ||
| #else | ||
| /// Calls the given closure with the contents of underlying storage. | ||
| /// | ||
| /// - note: Calling `withUnsafeBytes` multiple times does not guarantee that | ||
| /// the same buffer pointer will be passed in every time. | ||
| /// - warning: The buffer argument to the body should not be stored or used | ||
| /// outside of the lifetime of the call to the closure. | ||
| func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R | ||
| #endif | ||
|
|
||
| /// Calls the given closure with the contents of underlying storage. | ||
| /// | ||
| /// - note: Calling `withUnsafeBytes` multiple times does not guarantee that | ||
| /// the same span will be passed in every time. | ||
| @available(FoundationPreview 6.3, *) | ||
| func withBytes<R, E>(_ body: (RawSpan) throws(E) -> R) throws(E) -> R | ||
| } | ||
|
|
||
| extension ContiguousBytes where Self: ~Escapable, Self: ~Copyable { | ||
| /// Calls the given closure with the contents of underlying storage. | ||
| /// | ||
| /// - note: Calling `withUnsafeBytes` multiple times does not guarantee that | ||
| /// the same span will be passed in every time. | ||
| @_alwaysEmitIntoClient | ||
| public func withBytes<R, E>(_ body: (RawSpan) throws(E) -> R) throws(E) -> R { | ||
| #if !hasFeature(Embedded) | ||
| do { | ||
| return try withUnsafeBytes { (buffer) in | ||
| try body(buffer.bytes) | ||
| } | ||
| } catch let error { | ||
| // Note: withUnsafeBytes is rethrowing, so we have an "any Error" here that needs casting. | ||
| throw error as! E | ||
| } | ||
| #else | ||
| return try withUnsafeBytes { (buffer) throws(E) in | ||
| try body(buffer.bytes) | ||
| } | ||
| #endif | ||
| } | ||
| } | ||
|
|
||
| //===--- Collection Conformances ------------------------------------------===// | ||
|
|
@@ -43,69 +84,176 @@ extension ContiguousArray : ContiguousBytes where Element == UInt8 { } | |
|
|
||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension UnsafeRawBufferPointer : ContiguousBytes { | ||
| @inlinable | ||
| public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| #if !hasFeature(Embedded) | ||
| // Historical ABI | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| return try body(self) | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| return try body(self) | ||
| } | ||
| } | ||
|
|
||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension UnsafeMutableRawBufferPointer : ContiguousBytes { | ||
| @inlinable | ||
| public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| #if !hasFeature(Embedded) | ||
| // Historical ABI | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| return try body(UnsafeRawBufferPointer(self)) | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| return try body(UnsafeRawBufferPointer(self)) | ||
| } | ||
| } | ||
|
|
||
| // FIXME: When possible, expand conformance to `where Element : Trivial`. | ||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension UnsafeBufferPointer : ContiguousBytes where Element == UInt8 { | ||
| @inlinable | ||
| public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| #if !hasFeature(Embedded) | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| return try body(UnsafeRawBufferPointer(self)) | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| return try body(UnsafeRawBufferPointer(self)) | ||
| } | ||
| } | ||
|
|
||
| // FIXME: When possible, expand conformance to `where Element : Trivial`. | ||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension UnsafeMutableBufferPointer : ContiguousBytes where Element == UInt8 { | ||
| @inlinable | ||
| public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| #if !hasFeature(Embedded) | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| return try body(UnsafeRawBufferPointer(self)) | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| return try body(UnsafeRawBufferPointer(self)) | ||
| } | ||
| } | ||
|
|
||
| // FIXME: When possible, expand conformance to `where Element : Trivial`. | ||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension EmptyCollection : ContiguousBytes where Element == UInt8 { | ||
| @inlinable | ||
| public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| #if !hasFeature(Embedded) | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| return try body(UnsafeRawBufferPointer(start: nil, count: 0)) | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| return try body(UnsafeRawBufferPointer(start: nil, count: 0)) | ||
| } | ||
| } | ||
|
|
||
| // FIXME: When possible, expand conformance to `where Element : Trivial`. | ||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension CollectionOfOne : ContiguousBytes where Element == UInt8 { | ||
| @inlinable | ||
| public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| #if !hasFeature(Embedded) | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R { | ||
| let element = self.first! | ||
| return try Swift.withUnsafeBytes(of: element) { | ||
| return try body($0) | ||
| } | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| let element = self.first! | ||
| return try Swift.withUnsafeBytes(of: element) { (buffer) throws(E) in | ||
| return try body(buffer) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| //===--- Conditional Conformances -----------------------------------------===// | ||
|
|
||
| @available(macOS 10.10, iOS 8.0, watchOS 2.0, tvOS 9.0, *) | ||
| extension Slice : ContiguousBytes where Base : ContiguousBytes { | ||
| public func withUnsafeBytes<ResultType>(_ body: (UnsafeRawBufferPointer) throws -> ResultType) rethrows -> ResultType { | ||
| #if !hasFeature(Embedded) | ||
| @usableFromInline | ||
| @abi(func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R) | ||
| func __abi__withUnsafeBytes<ResultType>(_ body: (UnsafeRawBufferPointer) throws -> ResultType) rethrows -> ResultType { | ||
| let offset = base.distance(from: base.startIndex, to: self.startIndex) | ||
| return try base.withUnsafeBytes { ptr in | ||
| let slicePtr = ptr.baseAddress?.advanced(by: offset) | ||
| let sliceBuffer = UnsafeRawBufferPointer(start: slicePtr, count: self.count) | ||
| return try body(sliceBuffer) | ||
| } | ||
| } | ||
| #endif | ||
|
|
||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<ResultType, ErrorType>(_ body: (UnsafeRawBufferPointer) throws(ErrorType) -> ResultType) throws(ErrorType) -> ResultType { | ||
| let offset = base.distance(from: base.startIndex, to: self.startIndex) | ||
|
|
||
| #if !hasFeature(Embedded) | ||
| do { | ||
| return try base.withUnsafeBytes { (ptr) in | ||
| let slicePtr = ptr.baseAddress?.advanced(by: offset) | ||
| let sliceBuffer = UnsafeRawBufferPointer(start: slicePtr, count: self.count) | ||
| return try body(sliceBuffer) | ||
| } | ||
| } catch let error { | ||
| // Note: withUnsafeBytes is rethrowing, so we have an "any Error" here that needs casting. | ||
| throw error as! ErrorType | ||
| } | ||
| #else | ||
| return try base.withUnsafeBytes { (ptr) throws(ErrorType) in | ||
| let slicePtr = ptr.baseAddress?.advanced(by: offset) | ||
| let sliceBuffer = UnsafeRawBufferPointer(start: slicePtr, count: self.count) | ||
| return try body(sliceBuffer) | ||
| } | ||
| #endif | ||
| } | ||
| } | ||
|
|
||
| //===--- Span Conformances -----------------------------------------===// | ||
|
|
||
| @available(FoundationPreview 6.3, *) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a public conformance, right? We would need an API review. |
||
| extension RawSpan: ContiguousBytes { | ||
| } | ||
|
|
||
| @available(FoundationPreview 6.3, *) | ||
| extension MutableRawSpan: ContiguousBytes { | ||
| } | ||
|
|
||
| @available(FoundationPreview 6.3, *) | ||
| extension Span: ContiguousBytes where Element == UInt8 { | ||
| } | ||
|
|
||
| @available(FoundationPreview 6.3, *) | ||
| extension MutableSpan: ContiguousBytes where Element == UInt8 { | ||
| } | ||
|
|
||
| @available(FoundationInlineArray 6.3, *) | ||
| extension InlineArray: ContiguousBytes where Element == UInt8 { | ||
| @_alwaysEmitIntoClient | ||
| public func withUnsafeBytes<R, E>(_ body: (UnsafeRawBufferPointer) throws(E) -> R) throws(E) -> R { | ||
| return try span.withUnsafeBytes(body) | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import Testing | ||
|
|
||
| #if canImport(FoundationEssentials) | ||
| @testable import FoundationEssentials | ||
| #else | ||
| @testable import Foundation | ||
| #endif | ||
|
|
||
| enum HomeworkError: Error { | ||
| case dogAteIt | ||
| } | ||
|
|
||
| @available(FoundationPreview 6.3, *) | ||
| @discardableResult | ||
| func acceptContiguousBytes<T: ContiguousBytes & ~Escapable & ~Copyable>(_ bytes: borrowing T) -> Int { | ||
| do { | ||
| // Ensure that we can use withBytes with typed throws. | ||
| return try bytes.withBytes { (buffer) throws(HomeworkError) in | ||
| if buffer.isEmpty { | ||
| throw .dogAteIt | ||
| } | ||
|
|
||
| return buffer.byteCount | ||
| } | ||
| } catch let error { | ||
| precondition(error == .dogAteIt) | ||
| return -1 | ||
| } | ||
| } | ||
|
|
||
| @Suite("ContiguousBytesTests") | ||
| private struct ContiguousBytesTests { | ||
| @Test func span() throws { | ||
| if #available(FoundationPreview 6.3, *) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the function is already annotated as only available on macOS 26+, I don't think we need this |
||
| var bytes: [UInt8] = [1, 2, 3] | ||
| bytes.withUnsafeMutableBufferPointer { unsafeBytes in | ||
| acceptContiguousBytes(unsafeBytes.span) | ||
| acceptContiguousBytes(unsafeBytes.mutableSpan) | ||
| acceptContiguousBytes(unsafeBytes.span.bytes) | ||
|
|
||
| var ms = unsafeBytes.mutableSpan | ||
| acceptContiguousBytes(ms.bytes) | ||
| acceptContiguousBytes(ms.mutableBytes) | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming, are there any ABI implications on this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not ABI-breaking (or source-breaking) to make this change.