Minor Updates to ProgressManager API
#1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-yeo
changed the title
ProgressManager API with enhancementsProgressManager API
chloe-yeo
changed the title
ProgressManager API ProgressManager API
chloe-yeo
force-pushed
the
implementation/progress-manager-enhancements
branch
2 times, most recently
from
9661753 to
ebb8a07
Compare
chloe-yeo
force-pushed
the
implementation/progress-manager-enhancements
branch
2 times, most recently
from
ebb8a07 to
cfd13a8
Compare
…nt in summary methods
correct calling order of didSet add missing case
chloe-yeo
force-pushed
the
implementation/progress-manager-enhancements
branch
from
cfd13a8 to
554ff02
Compare
|
@swift-ci please test |
itingliu
approved these changes
Nov 4, 2025
| let p2 = Progress(totalUnitCount: 1, parent: overall, pendingUnitCount: 5) | ||
|
|
||
| await doSomething(subprogress: p2.makeChild(withPendingUnitCount: 1)) | ||
| await doSomething(subprogress: p2.subprogress(assigningCount: 1)) |
There was a problem hiding this comment.
This does look more consistent than the previous one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements for
ProgressManager, including:summary(of:)method signatures to takeKeyPathdidSetcalls