(142076445) Allow URL.standardized to return an empty string URL #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Would it make sense to avoid force unwrapping before returning from |
|
Yeah, I was thinking it could limit our ability to find other cases, but that is probably the safer approach, and I could always re-add the force-unwrap when testing inputs at desk. I'll add a |
|
@swift-ci please test |
itingliu
approved these changes
Jan 3, 2025
|
@swift-ci please test |
iCharlesHu
pushed a commit
to iCharlesHu/swift-foundation
that referenced
this pull request
Jan 7, 2025
…ftlang#1110) * (142076445) Allow URL.standardized to return an empty string URL * Add ?? self to prevent force-unwrap
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Mar 5, 2025
…ftlang#1110) * (142076445) Allow URL.standardized to return an empty string URL * Add ?? self to prevent force-unwrap
parkera
pushed a commit
that referenced
this pull request
Mar 5, 2025
* (141549683) Restore behavior of URL(string: "") returning nil (#1103) * (142076445) Allow URL.standardized to return an empty string URL (#1110) * (142076445) Allow URL.standardized to return an empty string URL * Add ?? self to prevent force-unwrap * (142446243) Compatibility behaviors for Swift URL (#1113) * (142589056) URLComponents.string should percent-encode colons in first path segment if needed (#1117) * (142667792) URL.absoluteString crashes if baseURL starts with colon (#1119) * (143159003) Don't encode colon if URLComponents path starts with colon (#1139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
URL.standardizedon a URL like../../../../removes the dot segments and produces an empty string.NSURLallows the empty string, and in the old implementation, this would return aURLthat wraps an empty stringNSURL.In the new implementation, we ultimately call
URL(string: "")when initializing this standardized URL, which returnsnilagain after #1103. SinceURL.standardizedreturns a non-nilURL, this would crash when unwrapped.We can allow
URL.standardized(and other methods that callURLComponents.url) to return an empty stringURLas they did previously by usingURL(string:relativeTo:)instead.