Skip to content

Tweak libswiftLexRegexLiteral interface #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

hamishknight
Copy link
Contributor

From the review feedback on swiftlang/swift#40595, update the interface here so it would have the ability to better recover from lexing errors in the future.

Update so it would have the ability to better
recover from lexing errors in the future.
@hamishknight
Copy link
Contributor Author

@swift-ci please test Linux

@hamishknight
Copy link
Contributor Author

@milseman I added a couple of extra platforms to the #availables to hopefully fix the build issue in https://ci.swift.org/job/swift-PR-macos/30333/

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. We'll eventually want a model of a diagnostics engine for the future, because we want to be able to issue notes and fixits and warnings, but this is a good lexing interface. The latter can be added to the parsing interface.

@milseman
Copy link
Member

@swift-ci please test linux platform

@hamishknight hamishknight merged commit 2244c53 into swiftlang:main Dec 17, 2021
@hamishknight hamishknight deleted the tweak-interface branch December 17, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants