Benchmark: option to output perf as csv #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
natecook1000
approved these changes
Oct 17, 2024
| $0.name < $1.name | ||
| } | ||
| var contents = """ | ||
| name,\ |
There was a problem hiding this comment.
Feels like we'll eventually get bitten by name having CSV-incompatible characters… is there a simple escaping step we could do here to forfend against that?
There was a problem hiding this comment.
You can escape the entire field in double double quotes, e.g. ""field 1""
There was a problem hiding this comment.
I'm going to not do so now, as I think it will put the quote in the field when opened in a spreadsheet. We can add that later or just have a policy that names not include commas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.