Treat capture 0 (i.e. the whole match) specially #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milseman
force-pushed
the
special_capture
branch
2 times, most recently
from
c9ffc99 to
5d7ff59
Compare
|
Perf improvement on top of #776: |
|
@swift-ci please test |
| var result = [AnyRegexOutput.ElementRepresentation]() | ||
|
|
||
| for (i, (cap, meStored)) in zip(captures, list.values).enumerated() { | ||
| result.append( |
There was a problem hiding this comment.
We should be able to reserve the correct capacity in result before this…
Suggested change
| result.append( | |
| result.reserveCapacity(capList.captures.count) | |
| result.append( |
Comment on lines
28
to
30
| if !cap.visibleInTypedOutput { | ||
| fatalError("Why does this work?") | ||
| } |
There was a problem hiding this comment.
Hmm, I'm still not hitting that fatal error. Did you push the tests that should trigger it?
Comment on lines
43
to
45
| guard typeErasedMatch is Output else { | ||
| fatalError() | ||
| } |
There was a problem hiding this comment.
This seems like it's doing the same thing as the as!. Do we want a custom error message with the fatal error? Could rewrite as guard let output = typeErasedMatch... if so.
milseman
force-pushed
the
special_capture
branch
from
5d7ff59 to
ffc9ce4
Compare
Rather than have the whole-match capture be a stored capture, we handle it specially. This speeds up processor resets as we do not need to reset a stored capture (especially when the regex has no other captures). It also speeds up the creation of save points and backtracking, as it's one less capture to save/restore.
milseman
force-pushed
the
special_capture
branch
from
ffc9ce4 to
1b77fb6
Compare
|
@swift-ci please test |
milseman
added a commit
to milseman/swift-experimental-string-processing
that referenced
this pull request
Dec 19, 2024
Rather than have the whole-match capture be a stored capture, we handle it specially. This speeds up processor resets as we do not need to reset a stored capture (especially when the regex has no other captures). It also speeds up the creation of save points and backtracking, as it's one less capture to save/restore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have the whole-match capture be a stored capture, we handle it specially. This speeds up processor resets as we do not need to reset a stored capture (especially when the regex has no other captures).
It also speeds up the creation of save points and backtracking, as it's one less capture to save/restore.
Built on top of #776