[swift/main] Add a string-specific search algorithm #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a string-specific search algorithm This adds a Boyer-Moore substring search algorithm, and updates the `firstRange(of:)` and `ranges(of:)` methods to use that when both pieces of the search are strings/substrings. * Substring search: iterative rather than recursive For large strings, a recursive search can run out of stack space. This eliminates the issue by looping within the `nextRange` function. * Dispatch string splitting to new searcher * Remove generic on SubstringSearcher * Remove unnecessary inlining annotations * Update string algorithms tests * Verify string/substring dispatch in algorithms * Add tests for string.replacing maxReplacements * Add fallback to naive search for small patterns * Improve some comments/formatting in the string search
|
@swift-ci Please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #715 for the
swift/mainbranch.