Skip to content

Refactor generator script #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 26, 2022
Merged

Refactor generator script #356

merged 7 commits into from
Apr 26, 2022

Conversation

milseman
Copy link
Member

No description provided.

@milseman
Copy link
Member Author

Refactors to have these helpers:

func captureTypeList(_ arity: Int) -> String {
  (0..<arity).map { "C\($0)" }.joined(separator: ", ")
}
func optionalCaptureTypeList(_ arity: Int) -> String {
  (0..<arity).map { "C\($0)?" }.joined(separator: ", ")
}

@milseman
Copy link
Member Author

Now numbers captures consistently, i.e. <W, C1, C2> instead of <W, C0, C1>

@milseman milseman requested a review from natecook1000 April 26, 2022 16:15
@milseman
Copy link
Member Author

Fixed indentation, the disfavoredOverload when empty was over indenting the declarations

@milseman
Copy link
Member Author

@swift-ci please test

@milseman milseman requested a review from rxwei April 26, 2022 17:48
natecook1000
natecook1000 approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@milseman milseman merged commit 435090d into swiftlang:main Apr 26, 2022
@milseman milseman deleted the factor_regenerator branch April 26, 2022 19:37
milseman added a commit to milseman/swift-experimental-string-processing that referenced this pull request Apr 27, 2022
@milseman
Refactor generator script (swiftlang#356)
b7062af 
* Number captures consistently
* Proper indentation
milseman added a commit that referenced this pull request Apr 28, 2022
@milseman
Refactor generator script (#356) (#363)
a75fe3a 
* Number captures consistently
* Proper indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 natecook1000 approved these changes

@rxwei rxwei Awaiting requested review from rxwei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milseman @natecook1000