[5.7] Update API for congruence with Unicode proposal #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a RegexBuilder API that represents the same as `\O` in regex syntax.
This also moves QuantificationBehavior from the RegexBuilder module down to _StringProcessing, and renames it to RegexRepetitionBehavior.
This will go back when 182da3b is merged into the 5.7 branch.
|
@swift-ci Please test |
rxwei
approved these changes
Apr 21, 2022
stephentyrone
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates two API points to align with the Unicode for String Processing proposal:
anyUnicodeScalarstatic property toRegexBuilder.CharacterClass— this functionality is already available via regex syntax as\O.reluctantQuantifiers()to arepetitionBehavior(_:)method that takes the preferred behavior for the modified regex. This includes a move of theQuantificationBehaviortype from theRegexBuildermodule to the_StringProcessingmodule, and a rename toRegexRepetitionBehavior.