Skip to content

[5.7] Expose matches, ranges and split #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Apr 21, 2022

This is based on top off #298

@Azoy Azoy requested review from milseman, rxwei and itingliu April 21, 2022 16:50
@itingliu
Copy link
Contributor

itingliu commented Apr 21, 2022

It looks like a lot of the commits in between are also included here. Or am I missing something?
Wait or is this another world PR that's going to replace the old world PR?

* Expose `matches`, `ranges` and `split`

Publicize these API per the String Processing Algorithms proposal. The proposed
ones return generic `Collection`, empowered by SE-0346. For now we'll wrap the
results with a concrete `Array` until the language feature is ready.

Co-authored-by: Michael Ilseman <michael.ilseman@gmail.com>
@Azoy Azoy force-pushed the matches-ranges-split branch from 20a1751 to 65ef2ae Compare April 21, 2022 16:54
@Azoy
Copy link
Contributor Author

Azoy commented Apr 21, 2022

@itingliu was just waiting for the first PR to get merged so we could rebase this one! 😅

@Azoy
Copy link
Contributor Author

Azoy commented Apr 21, 2022

@swift-ci please test

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Azoy Azoy merged commit dad77c5 into swiftlang:swift/release/5.7 Apr 21, 2022
@Azoy Azoy deleted the matches-ranges-split branch April 21, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants