Add Substring algorithms tests #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`firstMatch(of:)` was ignoring the start/endIndex when searching in substrings; this change fixes that issue. Also adds the 'in' label to `Regex.firstMatch(in:Substring)` to match the rest of the related APIs.
|
@swift-ci Please test |
itingliu
approved these changes
Apr 15, 2022
| @@ -123,7 +123,7 @@ extension Regex { | |||
| /// Find the first match in a substring | |||
| /// | |||
| /// Returns `nil` if no match is found and throws on abort | |||
| public func firstMatch(_ s: Substring) throws -> Regex<Output>.Match? { | |||
| public func firstMatch(in s: Substring) throws -> Regex<Output>.Match? { | |||
There was a problem hiding this comment.
I thought Output was renamed to RegexOutput?
There was a problem hiding this comment.
Regex's generic parameter is still named Output.
Azoy
pushed a commit
to Azoy/swift-experimental-string-processing
that referenced
this pull request
Apr 19, 2022
`firstMatch(of:)` was ignoring the start/endIndex when searching in substrings; this change fixes that issue. Also adds the 'in' label to `Regex.firstMatch(in:Substring)` to match the rest of the related APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firstMatch(of:)was ignoring the start/endIndex when searching in substrings; this change fixes that issue. Also adds the 'in' label toRegex.firstMatch(in:Substring)to match the rest of the related APIs.