Throwing matches and update to CustomMatchingRegexComponent #273
Conversation
|
Could anyone call out to @swift-ci for me? |
|
@swift-ci please test |
|
Tests are failing because I was still using the old function names before Michael's renaming cleanup |
itingliu
force-pushed
the
throwing-hooks
branch
from
1a1340c to
874c302
Compare
|
@swift-ci please test |
| @@ -293,13 +293,15 @@ extension Compiler.ByteCodeGen { | |||
| mutating func emitMatcher( | |||
| _ matcher: @escaping _MatcherInterface, | |||
| into capture: CaptureRegister? = nil | |||
| ) { | |||
| ) throws { | |||
There was a problem hiding this comment.
Hmm why does the compiler need to throw? It's only the underlying matcher that throws, right?
There was a problem hiding this comment.
Hmm you're right that it doesn't. I didn't understand how this works well so I thought it was needed. For my information why does the compiler need to throw in the case like emitTransform and emitCharacter?
There was a problem hiding this comment.
I think it's because they call emitNode which throws. emitNode throws because emitReference throws. emitReference throws because it needs to check the validity of references and throw RegexCompilationError.
- Update the name `CustomRegexComponent` to `CustomMatchingRegexComponent` per pitch - Adopt `throws` for `CustomMatchingRegexComponent` as added in swiftlang#261. Errors thrown by `CustomMatchingRegexComponent`'s conformers will be bubbled up to the engine and surfaced at client-side.
itingliu
force-pushed
the
throwing-hooks
branch
from
874c302 to
c6cdf6c
Compare
|
@swift-ci please test |
|
We need this in ASAP to make 5.7. Merging. |
Throwing matches and update to CustomMatchingRegexComponent
CustomRegexComponenttoCustomMatchingRegexComponentper pitchthrowsforCustomMatchingRegexComponentas added in Throwing customization hooks #261. Errors thrown byCustomMatchingRegexComponent's conformers will be bubbled up to the engine and surfaced at client-side.