Pitch: String processing algorithms #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Motivation for adding algorithms
- Motivation for `CustomRegexComponent`
- Design for added algorithms
- Design for `CustomRegexComponent`
- Add a few doc comments
Update pitch: Restructure the pitch to this structure: - Motivation for adding algorithms - Motivation for CustomRegexComponent - Design for added algorithms - Design for CustomRegexComponent Add a few doc comments. Update Foundation example.
itingliu
changed the title
itingliu
commented
Feb 25, 2022
| #### Trim prefix | ||
|
|
||
| ```swift | ||
| extension Collection { |
There was a problem hiding this comment.
I find myself squinting to see the differences between these functions. I wonder if it's easier to review if we group them by extension other than algorithms, like
extension Collection where Element: Equatable {
public func contains<S: Sequence>(_ other: S) -> Bool
public func trimmingPrefix<Prefix: Collection>(_ prefix: Prefix) -> SubSequence
}
extension BidirectionalCollection where SubSequence == Substring {
public func contains<R: RegexProtocol>(_ regex: R) -> Bool
public func starts<R: RegexProtocol>(with regex: R) -> Bool
}
milseman
reviewed
Feb 26, 2022
|
|
||
| You can conform your custom parser to `CustomRegexComponent`. Conformance is simple: implement the `match` function to return the upper bound of the matched substring, and the type represented by the matched range. It inherits from `RegexProtocol`, so you will be able to use it with all of the string algorithms that take a `RegexProtocol` type. | ||
|
|
||
| Here, we use Foundation framework's `FloatingPointFormatStyle<Double>.Currency` as an example. `FloatingPointFormatStyle<Double>.Currency` would conform to `CustomRegexComponent` by implementing the `match` function, with `Match` being a `Double`. It could also add a static function `.localizedCurrency(code:)` as a member of `RegexProtocol`, so you can refer to it as `.localizedCurrency(code:)` in the `Regex` result builder. |
There was a problem hiding this comment.
It really seems like this should be merged into the "proposed solution" sub-section, where the example's fresh in the reader's mind.
Editorial changes Co-authored-by: Michael Ilseman <michael.ilseman@gmail.com>
…differences in the two sections
- Add a comparison table for Python string functions and those of Swift - Add header docs for all except for `replacing`
itingliu
commented
Feb 28, 2022
|
@itingliu let me know when's a good time to do another pass over the prose. I don't want to conflict or interrupt any reorganizing you're doing. |
rxwei
reviewed
Mar 1, 2022
…ustomMatchingRegexComponent
…iu/swift-experimental-string-processing into pr/string-processing-pitch-update
milseman
reviewed
Mar 11, 2022
Co-authored-by: Michael Ilseman <michael.ilseman@gmail.com>
…sign; slim down future direction
milseman
approved these changes
Mar 14, 2022
I reworked it a little bit and added it back. Thanks! |
|
@swift-ci please test |
rxwei
pushed a commit
to rxwei/swift-experimental-string-processing
that referenced
this pull request
Mar 28, 2022
* Add string processing algorithms pitch Co-authored-by: Tim Vermeulen <tvermeulen@apple.com> Co-authored-by: Michael Ilseman <michael.ilseman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.