Add modulemap for static compilation #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling statically, we have to link against DispatchStubs in addition to the other dependencies, so we are defining a separate modulemap for that.
Contributor
Author
|
@swift-ci test linux |
compnerd
reviewed
Aug 4, 2020
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Why is the dispatch module required? This is the swift module which will encode the auto link information and be handled via auto-link extract no?
Contributor
Author
|
@compnerd The only difference between the existing modulemap and the new one is otherwise they are exactly the same. So as to why it is required, I don't know. |
Member
|
Oh, I get it. Its for the autolinking to its dependencies from the Swift module. LGTM with grumbling. |
compnerd
approved these changes
Aug 12, 2020
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Add modulemap for static compilation Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling statically, we have to link against DispatchStubs in addition to the other dependencies, so we are defining a separate modulemap for that.